Skip to content

fix issue 20042 - __vector CTFE crashes the compiler#10160

Merged
dlang-bot merged 2 commits intostablefrom
unknown repository
Jul 11, 2019
Merged

fix issue 20042 - __vector CTFE crashes the compiler#10160
dlang-bot merged 2 commits intostablefrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jul 10, 2019

This fix prevents the crash and a proper error message is issued, but doesn't add the code to accept the assign from slice to vector. This means that if this PR gets accepted then the issue would have to be reopened and converted to "enhancement".

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Basile-z! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20042 major __vector CTFE crashes the compiler

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10160"

@tsbockman
Copy link
Contributor

tsbockman commented Jul 10, 2019

This solution is fine by me; thanks for working on this.

Please have a look at issue 20041, as well - its symptom is even worse, but I suspect it has the same root cause. If this PR can fix both, a separate test case should be added for 20041, since its symptom is different.

@ghost
Copy link
Author

ghost commented Jul 11, 2019

The other issue is a 2.085 regression. This one crashed since much longer.

Copy link
Member

@ibuclaw ibuclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to change formatting here.

@dlang-bot dlang-bot merged commit 02df7b3 into dlang:stable Jul 11, 2019
wilzbach pushed a commit to wilzbach/dmd that referenced this pull request Jul 30, 2019
fix issue 20042 - __vector CTFE crashes the compiler
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants